scrable/TradeSkillMaster_PriceChecker
Watch
1
0
Fork
You've already forked TradeSkillMaster_PriceChecker
 0
Code Issues 3 Pull requests Projects Releases 4 Packages Wiki Activity Actions

Support for strings & small modifications #4

Merged
jerejere merged 8 commits from master into master 2020-03-28 11:15:50 -07:00
Conversation 3 Commits 8 Files changed 3 +18 -13
jerejere commented 2020-03-28 01:23:37 -07:00 (Migrated from github.com)
Copy link

.. Sorry for not using branches with this one.

  • Users can search with itemlinks or strings
    !price [Runecloth]
    !price Runecloth
  • Fixed descriptions of channels
    eg. desc = '/tsmpc guild CHANNEL' --> desc = '/tsmpc guildchannel CHANNEL'
  • Price message cleanup
    eg. brackets, no raid icon: Min [0g 10s 33c] Market [0g 9s 92c] Regional [0g 8s 62c]
.. Sorry for not using branches with this one. - Users can search with itemlinks or strings _!price [Runecloth] !price Runecloth_ - Fixed descriptions of channels eg. _desc = '/tsmpc guild CHANNEL'_ **-->** _desc = '/tsmpc guildchannel CHANNEL'_ - Price message cleanup eg. brackets, no raid icon: _Min [0g 10s 33c] Market [0g 9s 92c] Regional [0g 8s 62c]_
scrable commented 2020-03-28 11:15:59 -07:00 (Migrated from github.com)
Copy link

Seems like a decent enough idea, it could be useful.

Most of this code I just left as it was written by seraph1m. It could use cleaning up, especially the locales since they aren't used anymore when I rewrote the options commands.

I resolved a merge conflict with EventDetection.lua and merged it with your master. Please rebase your repo so this file won't conflict later 😃

Thanks for the idea!

Seems like a decent enough idea, it could be useful. Most of this code I just left as it was written by seraph1m. It could use cleaning up, especially the locales since they aren't used anymore when I rewrote the options commands. I resolved a merge conflict with `EventDetection.lua` and merged it with your master. Please rebase your repo so this file won't conflict later 😃 Thanks for the idea!
jerejere commented 2020-03-28 18:57:22 -07:00 (Migrated from github.com)
Copy link

I tried to rebase my master to your latest commit, but seems like I totally fucked up it. Twice. Actually +3 times. Sad.

This branch is 9 commits ahead of scrable:master.

As you can see I'm ~85% noob with Git. Fml.

I tried to rebase my master to your latest commit, but seems like I totally fucked up it. Twice. Actually +3 times. Sad. _This branch is 9 commits ahead of scrable:master._ As you can see I'm ~85% noob with Git. Fml.
scrable commented 2020-03-28 22:47:18 -07:00 (Migrated from github.com)
Copy link

No worries. Try and do a hard reset to commit 550227236846d2bf71cbf1dcb7a5f7b603fa970b

If it doesn't work out, you can always just re-fork the repo and start fresh

No worries. Try and do a hard reset to commit `550227236846d2bf71cbf1dcb7a5f7b603fa970b` If it doesn't work out, you can always just re-fork the repo and start fresh
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
scrable/TradeSkillMaster_PriceChecker!4
No description provided.